Open
Conversation
…er, utils needed for log manipulation
Updated ToolsViewerViewModel.kt with new ToolMenuItem Updated DittoToolsViewer.kt to include log viewer as an option for tooling Classes and view models related to the LogViewer and LogDetail screens.
Juan Peralta (jperalta-ditto)
requested a review
from a team
as a code owner
Juan Peralta (jperalta-ditto)
requested review from
a team and
Jeremy (mrjeremystookey)
and removed request for
a team
Increases padding on LogFileScreen and LogDetailsScreen for better spacing and alignment.
Adds an 8.dp spacer to improve layout in the LogFileScreen.
Adds a legend to display the colors for each log level. This provides users with a clear visual key for interpreting the log entries. Additionally, this commit includes the following UI enhancements: * Replaces hardcoded text with string resources for better localization and maintainability. * Refreshes the color palette for log levels to improve readability. * Removes the experimental `OptIn` for Material3 components.
Adds a legend to display the colors for each log level. This provides users with a clear visual key for interpreting the log entries. Additionally, this commit includes the following UI enhancements: * Replaces hardcoded text with string resources for better localization and maintainability. * Refreshes the color palette for log levels to improve readability. * Removes the experimental `OptIn` for Material3 components.
Adds a floating action button to the log file screen that appears when the user has scrolled down. Tapping this button scrolls the list back to the top.
Update Utils to avoid using context minor cleanup.
Jeremy (mrjeremystookey)
approved these changes
Feb 20, 2026
| espresso-core = { group = "androidx.test.espresso", name = "espresso-core", version.ref = "espresso-core" } | ||
| material = { group = "com.google.android.material", name = "material", version.ref = "material" } | ||
| androidx-webkit = { group = "androidx.webkit", name = "webkit", version.ref = "webkit" } | ||
| moshi-kotlin = { module = "com.squareup.moshi:moshi-kotlin", version.ref = "moshiKotlin" } |
There was a problem hiding this comment.
Why moshi instead of kotlinx serialization? The latter is more commonly used and likely to already be used by a lot of Android apps.
Comment on lines
+372
to
+374
| <img src="/Img/log_details.png" alt="Log Details" style="width: 30%; min-width: 250px; max-width: 300px;"> | ||
| <img src="/Img/log_viewer.png" alt="Log Viewer" style="width: 30%; min-width: 250px; max-width: 300px;"> | ||
| <img src="/Img/log_tailing.png" alt="Log Tails" style="width: 30%; min-width: 250px; max-width: 300px;"> |
There was a problem hiding this comment.
nit: the folder name Img is not a full word and also starts with a capital which looks like lmg in github's file listing. To avoid ambiguity, a name like images is more clear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add log viewer screens. This will allow endusers to actively go through current small peer log on device.